deepthi912 commented on issue #12635: URL: https://github.com/apache/pinot/issues/12635#issuecomment-2063150350
According to my understanding the dictEnabledColumn checks if columns are dictionary supported and not raw indexed. Since inverted index support it, it would return true. In json and text indexes we are not enabling dictionary support for better storage capabilities I imagine. So in such case, I feel this condition should be !originalConfig.getConfig(StandardIndexes.inverted()).isEnabled() || !dictEnabledColumn @npawar @jadami10 correct me if my analysis is wrong here. https://github.com/apache/pinot/blob/3397986ada9b3f978c7d3fa6492986414e4a11d4/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java#L143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
