gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1565315967


##########
pinot-broker/src/test/java/org/apache/pinot/broker/querylog/QueryLoggerTest.java:
##########
@@ -259,11 +259,9 @@ private QueryLogger.QueryLogParams generateParams(boolean 
isGroupLimitHit, int n
     response.setExceptions(
         IntStream.range(0, numExceptions)
             .mapToObj(i -> new 
ProcessingException()).collect(Collectors.toList()));
-    response.setOfflineTotalCpuTimeNs(14);

Review Comment:
   BTW, this is why in lines 110 an 111 I had to modify the result. Before we 
were returning the synthetic values 14 and 18 and now we return 48 and 60 which 
is the sum of 15, 16 and 17 and 19, 20 and 21 respectively.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to