Jackie-Jiang commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1565231863
##########
pinot-common/src/main/java/org/apache/pinot/common/datatable/DataTable.java:
##########
@@ -100,7 +110,7 @@ enum MetadataValueType {
* - NEVER decrease MAX_ID
* Otherwise, backward compatibility will be broken.
*/
- enum MetadataKey {
+ enum MetadataKey implements StatMap.Key {
Review Comment:
How many of the keys apply to leaf stage? Should we consider adding a
separate key set for leaf stage as a clean start? I have a little bit concern
on managing both v1 and v2 stats in the same class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
