jackjlli commented on code in PR #12907:
URL: https://github.com/apache/pinot/pull/12907#discussion_r1561751433
##########
pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNative.java:
##########
@@ -127,7 +127,7 @@ private static BrokerResponseNative
getBrokerResponseExplainPlanOutput() {
/**
* Get a new empty {@link BrokerResponseNative}.
*/
- public static BrokerResponseNative empty() {
+ private static BrokerResponseNative empty() {
return new BrokerResponseNative();
Review Comment:
I see your point. It seems there are quite a few fields that need to be
updated. That doesn't make sense to just return an instance here. Let me think
of some other ways to do it. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
