Jackie-Jiang commented on code in PR #12907:
URL: https://github.com/apache/pinot/pull/12907#discussion_r1561651910
##########
pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNative.java:
##########
@@ -127,7 +127,7 @@ private static BrokerResponseNative
getBrokerResponseExplainPlanOutput() {
/**
* Get a new empty {@link BrokerResponseNative}.
*/
- public static BrokerResponseNative empty() {
+ private static BrokerResponseNative empty() {
return new BrokerResponseNative();
Review Comment:
Does it make sense to just return the singleton instance here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
