shounakmk219 commented on PR #12764: URL: https://github.com/apache/pinot/pull/12764#issuecomment-2031015956
Not sure if implementations of `BrokerRequestHandler. handleRequest` are fine with a null header. `FineGrainedAccessControl.hasAccess` interface which is invoked in `BaseBrokerRequestHandler.handleRequest` may be sensitive to headers based on provided implementation. Technically the util only breaks if invoked through tests with null header as existing code path does not pass a null header anywhere. I have handled this at [test side code](https://github.com/apache/pinot/pull/12417/files#diff-ef432222ed63283ab900bf309612a3c4b6d2a0d1e15abc76fad46a19b2b1750cR168) itself earlier during introduction of the util. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
