klsince commented on code in PR #12451:
URL: https://github.com/apache/pinot/pull/12451#discussion_r1509628827
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -359,6 +357,12 @@ public boolean isPartialUpsertEnabled() {
&& _tableUpsertMetadataManager.getUpsertMode() ==
UpsertConfig.Mode.PARTIAL;
}
+ private boolean isUpsertPreloadEnabled() {
+ UpsertConfig upsertConfig = _tableConfig.getUpsertConfig();
+ return _tableUpsertMetadataManager != null && _segmentPreloadExecutor !=
null && upsertConfig != null
Review Comment:
Good question. I followed the method call below used to create partition
mgr, as that's the entry point for preloading. And this is only called in
`addSegment()` or `handleUpsert()` methods. So afaik, we should be good to
check this at the beginning of the addSegment() method.
```
... _tableUpsertMetadataManager.getOrCreatePartitionManager(partitionId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
