zhtaoxiang commented on code in PR #12522:
URL: https://github.com/apache/pinot/pull/12522#discussion_r1511600582
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1661,22 +1666,35 @@ private void makeStreamConsumer(String reason) {
closePartitionGroupConsumer();
}
_segmentLogger.info("Creating new stream consumer for topic partition {} ,
reason: {}", _clientId, reason);
- _partitionGroupConsumer =
- _streamConsumerFactory.createPartitionGroupConsumer(_clientId,
_partitionGroupConsumptionStatus);
- _partitionGroupConsumer.start(_currentOffset);
+ try {
+ _partitionGroupConsumer =
+ _streamConsumerFactory.createPartitionGroupConsumer(_clientId,
_partitionGroupConsumptionStatus);
+ _partitionGroupConsumer.start(_currentOffset);
+ } catch (Exception e) {
+ _segmentLogger.error("Faced exception while trying to recreate stream
consumer for topic partition {} reason {}",
+ _clientId, reason, e);
+ _serverMetrics.addMeteredTableValue(_clientId,
ServerMeter.STREAM_CONSUMER_CREATE_EXCEPTIONS, 1L);
+ throw e;
+ }
}
/**
* Checkpoints existing consumer before creating a new consumer instance
* Assumes there is a valid instance of {@link PartitionGroupConsumer}
*/
private void recreateStreamConsumer(String reason) {
- _segmentLogger.info("Recreating stream consumer for topic partition {},
reason: {}", _clientId, reason);
- _currentOffset = _partitionGroupConsumer.checkpoint(_currentOffset);
- closePartitionGroupConsumer();
- _partitionGroupConsumer =
- _streamConsumerFactory.createPartitionGroupConsumer(_clientId,
_partitionGroupConsumptionStatus);
- _partitionGroupConsumer.start(_currentOffset);
+ try {
+ _segmentLogger.info("Recreating stream consumer for topic partition {},
reason: {}", _clientId, reason);
+ _currentOffset = _partitionGroupConsumer.checkpoint(_currentOffset);
+ closePartitionGroupConsumer();
Review Comment:
can you please help me understand why re-throw the exception can address the
potential issue I mentioned above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
