gortiz commented on code in PR #12522:
URL: https://github.com/apache/pinot/pull/12522#discussion_r1510773637
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -427,6 +427,9 @@ protected boolean consumeLoop()
try {
messageBatch =
_partitionGroupConsumer.fetchMessages(_currentOffset, null,
_streamConfig.getFetchTimeoutMillis());
+ //track realtime rows fetched on a table level. This included valid +
invalid rows
+ _serverMetrics.addMeteredTableValue(_clientId,
ServerMeter.REALTIME_ROWS_FETCHED,
+ messageBatch.getMessageCount());
Review Comment:
I think this is not correct. It should be
`messageBatch.getUnfilteredMessageCount()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
