aditya0811 commented on issue #12367:
URL: https://github.com/apache/pinot/issues/12367#issuecomment-1969084205
> @aditya0811 Thanks for taking this issue! I feel the problem is from the
implicit cast from float to double within the double comparison. The literal is
parsed as double, thus causing the implicit cast. In order to reproduce the
issue, we need to pick a float value which will change when casting to double.
So, shouldn't we then consider this as bug, in L434
BinaryOperatorTransformFunction.java, rather than updating UT? Maybe explore
BigDecimal, similar to BigDecimal and float comparison in L441
`_intValuesSV[i] =
getIntResult(BigDecimal.valueOf(leftValues[i]).compareTo(rightBigDecimalValues[i]));`
> In order to reproduce the issue, we need to pick a float value which will
change when casting to double.
Let me try this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
