aditya0811 commented on issue #12367: URL: https://github.com/apache/pinot/issues/12367#issuecomment-1967249666
Hello Jackie, I was trying to identify if there is any gap in the test. I can think of two possible reasons that this test could fail a) The case statement computation is incorrect. b) The predicate results are incorrect. Primarily I observed the difference in the way we compare the values in a) in L434 BinaryOperatorTransformFunction.java `_intValuesSV[i] = getIntResult(Double.compare(leftValues[i], rightDoubleValues[i]));` Here we are comparing float and double, as leftValues[i] is float and rightDoubleValues[i] is double. and in (b) L724 CaseTransformFunctionTest.java which results in expectedValues[i] in the assert statement in L345 BaseTransformFunctionTest `results[i] = _floatSVValues[i] == _floatSVValues[INDEX_TO_COMPARE];` I tried running the test only for that assert statement 100k times with only intSVValues and floatSVValues as test data. All passed. So been unable to conclude anything. Do we have any more information for this test like, if it specific to expression or any binary function? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
