Jackie-Jiang commented on code in PR #12498:
URL: https://github.com/apache/pinot/pull/12498#discussion_r1505086319
##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManagerStatelessTest.java:
##########
@@ -212,17 +212,23 @@ public void testAddRemoveInstance() {
String instanceName = "Server_localhost_" + NUM_SERVER_INSTANCES;
List<String> allInstances = _helixResourceManager.getAllInstances();
assertFalse(allInstances.contains(instanceName));
+ List<String> allLiveInstances = _helixResourceManager.getAllInstances();
Review Comment:
Same for other checks
```suggestion
List<String> allLiveInstances =
_helixResourceManager.getAllLiveInstances();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
