ankitsultana commented on code in PR #12498:
URL: https://github.com/apache/pinot/pull/12498#discussion_r1503731956
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotInstanceRestletResource.java:
##########
@@ -108,6 +108,19 @@ public Instances getAllInstances() {
return new Instances(_pinotHelixResourceManager.getAllInstances());
}
+ @GET
+ @Path("/liveinstances")
+ @Authorize(targetType = TargetType.CLUSTER, action =
Actions.Cluster.GET_INSTANCE)
+ @Produces(MediaType.APPLICATION_JSON)
+ @ApiOperation(value = "List all live instances")
Review Comment:
Would this also list instances that have temporarily disconnected from
Helix? (due to GC, regular restart, etc.)
If not, might be good to call it out explicitly in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
