xiangfu0 commented on code in PR #12389:
URL: https://github.com/apache/pinot/pull/12389#discussion_r1495126555
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerHealthCheck.java:
##########
@@ -45,19 +47,26 @@
import static
org.apache.pinot.spi.utils.CommonConstants.SWAGGER_AUTHORIZATION_KEY;
-
+@Singleton
@Api(tags = "Health", authorizations = {@Authorization(value =
SWAGGER_AUTHORIZATION_KEY)})
@SwaggerDefinition(securityDefinition =
@SecurityDefinition(apiKeyAuthDefinitions = @ApiKeyAuthDefinition(name =
HttpHeaders.AUTHORIZATION, in =
ApiKeyAuthDefinition.ApiKeyLocation.HEADER, key = SWAGGER_AUTHORIZATION_KEY)))
@Path("/")
public class PinotBrokerHealthCheck {
- @Inject
- @Named(BrokerAdminApiApplication.BROKER_INSTANCE_ID)
+
private String _instanceId;
- @Inject
private BrokerMetrics _brokerMetrics;
+ private Instant _startTime;
Review Comment:
Can you try to follow the Inject pattern for startTime as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
