suyashpatel98 commented on code in PR #12389:
URL: https://github.com/apache/pinot/pull/12389#discussion_r1483917499
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/BrokerAdminApiApplication.java:
##########
@@ -109,6 +112,8 @@ protected void configure() {
bind(brokerConf.getProperty(CommonConstants.Broker.CONFIG_OF_BROKER_ID)).named(BROKER_INSTANCE_ID);
bind(serverRoutingStatsManager).to(ServerRoutingStatsManager.class);
bind(accessFactory).to(AccessControlFactory.class);
+ bind(instanceId).named(BrokerAdminApiApplication.BROKER_INSTANCE_ID);
+ bind(pinotBrokerHealthCheck).to(PinotBrokerHealthCheck.class);
Review Comment:
This is to register objects with the DI framework because these were
instantiated manually. As mentioned in the description in order to preserve the
start time, it is essential to create an object at start time and ensure that
it exists through out the lifecycle of the application
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
