ankitsultana commented on code in PR #12353:
URL: https://github.com/apache/pinot/pull/12353#discussion_r1482240176
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/RoundRobinURIProvider.java:
##########
@@ -63,4 +78,33 @@ public URI next() {
_index = (_index + 1) % _uris.length;
return result;
}
+
+ public URI[] resolveHostToIPAddresses(URI originalUri)
Review Comment:
I think this and the following method shouldn't be public, since we are
anyways taking these args as input. To be more precise: if we create an object
of `RoundRobinURIProvider` with some URIs, then we shouldn't allow callers to
bypass those URIs (they should simply call `#next`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
