ankitsultana commented on code in PR #12353:
URL: https://github.com/apache/pinot/pull/12353#discussion_r1478254217
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/RoundRobinURIProvider.java:
##########
@@ -54,6 +55,14 @@ public RoundRobinURIProvider(URI originalUri)
_index = new Random().nextInt(_uris.length);
}
+ public RoundRobinURIProvider(List<URI> uris) {
Review Comment:
javadocs say that this class is supposed to resolve the hostname to multiple
IP addresses. This ctor breaks that definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
