chenboat commented on code in PR #12317:
URL: https://github.com/apache/pinot/pull/12317#discussion_r1479019052
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/fetcher/HttpSegmentFetcher.java:
##########
@@ -48,6 +48,19 @@ protected void doInit(PinotConfiguration config) {
_httpClient = new
FileUploadDownloadClient(HttpClientConfig.newBuilder(config).build());
}
+ public HttpSegmentFetcher() {
+ }
+
+ public HttpSegmentFetcher(FileUploadDownloadClient httpClient,
PinotConfiguration config) {
+ _httpClient = httpClient;
+ _retryCount = config.getProperty(RETRY_COUNT_CONFIG_KEY,
DEFAULT_RETRY_COUNT);
Review Comment:
Base init does doInit() which uses a hard coded httpClient. This PR does not
change that behavior. Meanwhile I put this constructor as test use only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
