chenboat commented on code in PR #12317:
URL: https://github.com/apache/pinot/pull/12317#discussion_r1479018283
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/fetcher/SegmentFetcher.java:
##########
@@ -49,4 +50,16 @@ File fetchUntarSegmentToLocalStreamed(URI uri, File dest,
long rateLimit, Atomic
*/
void fetchSegmentToLocal(List<URI> uri, File dest)
throws Exception;
+
+ /**
+ *
Review Comment:
I added the description of how the methods in the impl class. In this
interface, I just emphasize on the contract.
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/fetcher/BaseSegmentFetcher.java:
##########
@@ -109,6 +112,38 @@ public File fetchUntarSegmentToLocalStreamed(URI uri, File
dest, long rateLimit,
throw new UnsupportedOperationException();
}
+ // Download segment to a local location with retries.
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
