vrajat commented on code in PR #12157:
URL: https://github.com/apache/pinot/pull/12157#discussion_r1434819785
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1648,6 +1648,15 @@ private void makeStreamConsumer(String reason) {
_segmentLogger.info("Creating new stream consumer for topic partition {} ,
reason: {}", _clientId, reason);
_partitionGroupConsumer =
_streamConsumerFactory.createPartitionGroupConsumer(_clientId,
_partitionGroupConsumptionStatus);
+ try {
+ _partitionGroupConsumer.validateStreamState(_currentOffset);
+ _serverMetrics.setValueOfPartitionGauge(_tableNameWithType, 0,
+ ServerGauge.INVALID_REALTIME_STREAM_STATE_EXCEPTION, 0);
+ } catch (PermanentConsumerException pce) {
Review Comment:
I wasnt sure if the ingest should be stopped. After a couple of
conversations the feedback is that it should be stopped. I'll bubble up the
exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
