gortiz commented on code in PR #12242:
URL: https://github.com/apache/pinot/pull/12242#discussion_r1454925120
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/VarByteChunkSVForwardIndexReader.java:
##########
@@ -85,6 +85,10 @@ private String getStringCompressed(int docId,
ChunkReaderContext context) {
int length = valueEndOffset - valueStartOffset;
byte[] bytes = _reusableBytes.get();
+ if (bytes.length < _lengthOfLongestEntry) {
Review Comment:
It is clear that having a `ThreadLocal<byte[]>` per column is bad. My
understanding is that you are proposing two solutions:
1. Either use a single ThreadLocal byte[] per thread.
2. Move the byte[] to reader context.
I think `2` is better, but I'm fine with `1` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
