wirybeaver commented on code in PR #12242:
URL: https://github.com/apache/pinot/pull/12242#discussion_r1453781995
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/VarByteChunkSVForwardIndexReader.java:
##########
@@ -85,6 +85,10 @@ private String getStringCompressed(int docId,
ChunkReaderContext context) {
int length = valueEndOffset - valueStartOffset;
byte[] bytes = _reusableBytes.get();
+ if (bytes.length < _lengthOfLongestEntry) {
Review Comment:
Do you mean allocating one byte[] per Context is totally fine?
Cache byte[] per query worker is not aggressive as the screenshot shows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
