gortiz commented on code in PR #12223:
URL: https://github.com/apache/pinot/pull/12223#discussion_r1445859224
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/dictionary/DictionaryIndexType.java:
##########
@@ -285,7 +302,15 @@ public static Dictionary read(PinotDataBuffer dataBuffer,
ColumnMetadata metadat
boolean loadOnHeap = indexConfig.isOnHeap();
if (loadOnHeap) {
String columnName = metadata.getColumnName();
- LOGGER.info("Loading on-heap dictionary for column: {}", columnName);
+ OnHeapDictionaryConfig onHeapConfig =
indexConfig.getOnHeapDictionaryConfig();
+ if (onHeapConfig != null && onHeapConfig.isEnableInterning()) {
+ _strInternerInfoMap.putIfAbsent(columnName, new
FALFInterner<>(onHeapConfig.getInternerCapacity()));
Review Comment:
What if two different tables have a column with the same name and both have
this feature enabled but different interner capacity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
