gortiz commented on code in PR #12223:
URL: https://github.com/apache/pinot/pull/12223#discussion_r1445856207
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java:
##########
@@ -92,6 +92,8 @@ public class IndexingConfig extends BaseJsonConfig {
private JsonNode _tierOverwrites;
+ private Map<String, OnHeapDictionaryConfig> _onHeapDictionaryConfigs;
Review Comment:
I would recommend *against* this specific change. The index config
management is very complex because we can define things in different places.
The index-spi feature provide a nice way to add expressiveness in our config
without making the code more complex (just store everything in the IndexConfig
class and serialize/deserialize with jackson).
We need to keep backward compatibility, so we needed to make the
deserialization code a bit uglier to support that, but by convention new
features (like this one) should only be configurable using the new syntax.
Otherwise the index config complexity would increase in time, which is just the
opposite we wanted to do with index-spi.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
