tibrewalpratik17 commented on issue #12217: URL: https://github.com/apache/pinot/issues/12217#issuecomment-1879222077
> How does the type coercion rule work when in the input string is unexpected? I haven't looked into pinot's mechanism of handling type coercion for its config values. Is it actually being used during config parsing? It throws an exception if it encounters anything other than Number, String, Boolean. In these datatypes, it defaults to false which should be the intent with `deleteRecordColumn`. https://github.com/apache/pinot/blob/436968e080e89cdf4e08ab064e47cc70b1eb6491/pinot-spi/src/main/java/org/apache/pinot/spi/utils/BooleanUtils.java#L42-L54 > If you can add more validation in the TableConfigUtils for this config, instead of strict type check, I am fine with that. Blindly removing the check is a bit much. @navina any suggestions on this? Should we check for String and Number rather than removing Boolean as per coercion logic? > transform function are applied after upsert occurs (IIUC) this means if user wanted to convert a source field from the stream connector from its native type to a boolean type then write it into the upsert delete record column, it is not possible. @walterddr are we sure about this? Then how does partial-upserts work? Before applying the transformation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
