davecromberge commented on issue #12111: URL: https://github.com/apache/pinot/issues/12111#issuecomment-1851908193
@Jackie-Jiang thank you for your input! When I started considering solutions, I had similar inclinations to capture the relationships between value aggregators but I was going to do it internally. Giving the end-user control over which function to use is better. In the meantime, this [diff](https://github.com/apache/pinot/compare/master...davecromberge:attempt-1/virtual-functions?expand=1) shows the fundamental changes that I had in mind to implement the virtual aggregation functions - I'd be interested in what you think. The advantage of this approach is that the internals for constructing a StarTree remains unchanged. When loading the StarTree, the forward index is re-used for all virtual aggregation functions in order to correctly retrieve a Datasource. Note: this draft implementation might not address all corner-cases in the query evaluation part and furthermore it only supports the StarTreeV2. I would like to explore your idea further in a new branch and will share further results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
