walterddr commented on PR #11932:
URL: https://github.com/apache/pinot/pull/11932#issuecomment-1816876827
based on the QueryContext definition
```
// Limit of number of groups stored in each segment
private int _numGroupsLimit =
InstancePlanMakerImplV2.DEFAULT_NUM_GROUPS_LIMIT;
// Minimum number of groups to keep per segment when trimming groups for
SQL GROUP BY
private int _minSegmentGroupTrimSize =
InstancePlanMakerImplV2.DEFAULT_MIN_SEGMENT_GROUP_TRIM_SIZE;
// Minimum number of groups to keep across segments when trimming groups
for SQL GROUP BY
private int _minServerGroupTrimSize =
InstancePlanMakerImplV2.DEFAULT_MIN_SERVER_GROUP_TRIM_SIZE;
// Trim threshold to use for server combine for SQL GROUP BY
private int _groupTrimThreshold =
InstancePlanMakerImplV2.DEFAULT_GROUPBY_TRIM_THRESHOLD;
```
looks like the differences of these configurations are basically controlling
the maximum number of groups to keep in
1. segment level; 2. server level combine
however my argument: if any of these threshold were hit, then we have no
accurate results yes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
