vvivekiyer opened a new pull request, #11932: URL: https://github.com/apache/pinot/pull/11932
This PR contains a couple of usability improvements for GroupBy queries **Change1: `numGroupsLimitReached`** * One of the uses of this metadata is to help users determine if their groupBy results could be partial or potentially inaccurate. * This metadata is currently set if the number of groupBy keys collected matches the `num.groups.limit` irrespective of whether some groupBy keys have been ignored or not. * Added a fix for this in this PR **Change2: Better Visibility for User for potentially inaccurate GroupBy** * Due to segment trimming and server-level trimming, it's possible that the groupBy results are not perfectly accuracte. * In such case, we should expose a metadata to inform the user about this potential inaccuracy. * Added a metadata field called `isAccuracteGroupBy` which will be set to true only if no trimming/ignoring has taken place at the server or segment level. **Change3: User option to fail query if groupBy is potentially inaccurate** * The user should be able to potentially fail queries if they wish to perform perfectly accurate GroupBy. We can perhaps provide a queryOption for this. * I'm working on this part. Will update PR with these changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
