vvivekiyer commented on code in PR #11984:
URL: https://github.com/apache/pinot/pull/11984#discussion_r1393784447
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java:
##########
@@ -173,6 +173,15 @@ public static Integer
getMinServerGroupTrimSize(Map<String, String> queryOptions
return minServerGroupTrimSizeString != null ?
Integer.parseInt(minServerGroupTrimSizeString) : null;
}
+ @Nullable
+ public static Integer getMinBrokerGroupTrimSize(Map<String, String>
queryOptions) {
+ if (queryOptions == null) {
+ return null;
+ }
Review Comment:
Moved this check into (Streaming/Broker)ReduceService. This check is needed
because unlike servers (where queryOption cannot be null because of
timeout,etc), it can be null for brokers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
