Jackie-Jiang commented on code in PR #11984:
URL: https://github.com/apache/pinot/pull/11984#discussion_r1393017745
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java:
##########
@@ -206,6 +215,9 @@ public static Integer
getMaxInitialResultHolderCapacity(Map<String, String> quer
@Nullable
public static Integer getGroupTrimThreshold(Map<String, String>
queryOptions) {
+ if (queryOptions == null) {
+ return null;
+ }
Review Comment:
Same here
```suggestion
```
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java:
##########
@@ -173,6 +173,15 @@ public static Integer
getMinServerGroupTrimSize(Map<String, String> queryOptions
return minServerGroupTrimSizeString != null ?
Integer.parseInt(minServerGroupTrimSizeString) : null;
}
+ @Nullable
+ public static Integer getMinBrokerGroupTrimSize(Map<String, String>
queryOptions) {
+ if (queryOptions == null) {
+ return null;
+ }
Review Comment:
Let's follow the same convention by assuming `queryOptions` is not null
```suggestion
```
##########
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BaseReduceService.java:
##########
@@ -50,15 +50,15 @@ public abstract class BaseReduceService {
protected final ExecutorService _reduceExecutorService;
protected final int _maxReduceThreadsPerQuery;
- protected final int _groupByTrimThreshold;
- protected final int _minGroupTrimSize;
+ protected final int _groupByTrimThresholdCfg;
Review Comment:
(minor) No need to change this. Member variable indicates it is not from
query
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
