Jackie-Jiang commented on code in PR #11953:
URL: https://github.com/apache/pinot/pull/11953#discussion_r1391841066
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstancePartitionSelector.java:
##########
@@ -29,12 +29,14 @@ abstract class InstancePartitionSelector {
protected final InstanceReplicaGroupPartitionConfig
_replicaGroupPartitionConfig;
protected final String _tableNameWithType;
protected final InstancePartitions _existingInstancePartitions;
+ protected final boolean _minimizeDataMovement;
public InstancePartitionSelector(InstanceReplicaGroupPartitionConfig
replicaGroupPartitionConfig,
- String tableNameWithType, InstancePartitions existingInstancePartitions)
{
+ String tableNameWithType, InstancePartitions existingInstancePartitions,
boolean minimizeDataMovement) {
_replicaGroupPartitionConfig = replicaGroupPartitionConfig;
_tableNameWithType = tableNameWithType;
_existingInstancePartitions = existingInstancePartitions;
+ _minimizeDataMovement = minimizeDataMovement;
Review Comment:
```suggestion
// For backward compatibility, enable minimize data movement when it is
enabled in top level or instance partition selector level
_minimizeDataMovement = minimizeDataMovement ||
replicaGroupPartitionConfig.isMinimizeDataMovement();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
