jackjlli commented on PR #11953: URL: https://github.com/apache/pinot/pull/11953#issuecomment-1800431309
> We should not access `InstanceReplicaGroupPartitionConfig` in `InstanceTagPoolSelector`. We can consider moving `minimizeDataMovement` flag into `InstanceAssignmentConfig` That's good point! How about we just pass the boolean `_minimizeDataMovement` parameter down to `InstanceTagPoolSelector` class, because that's the only parameter I need in that class? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
