walterddr commented on code in PR #11857:
URL: https://github.com/apache/pinot/pull/11857#discussion_r1380842197


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/TextIndexUtils.java:
##########
@@ -43,9 +43,9 @@ private TextIndexUtils() {
 
   static void cleanupTextIndex(File segDir, String column) {
     // Remove the lucene index file and potentially the docId mapping file.
-    File luceneIndexFile = new File(segDir, column + 
Indexes.LUCENE_TEXT_INDEX_FILE_EXTENSION);
+    File luceneIndexFile = new File(segDir, column + 
Indexes.LUCENE_V9_TEXT_INDEX_FILE_EXTENSION);

Review Comment:
   :+1:



##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/V1Constants.java:
##########
@@ -44,14 +44,17 @@ public static class Indexes {
     public static final String UNSORTED_MV_FORWARD_INDEX_FILE_EXTENSION = 
".mv.fwd";
     public static final String BITMAP_INVERTED_INDEX_FILE_EXTENSION = 
".bitmap.inv";
     public static final String BITMAP_RANGE_INDEX_FILE_EXTENSION = 
".bitmap.range";
-    public static final String FST_INDEX_FILE_EXTENSION = ".lucene.fst";
     public static final String JSON_INDEX_FILE_EXTENSION = ".json.idx";
     public static final String NATIVE_TEXT_INDEX_FILE_EXTENSION = 
".nativetext.idx";
     public static final String H3_INDEX_FILE_EXTENSION = ".h3.idx";
     public static final String BLOOM_FILTER_FILE_EXTENSION = ".bloom";
     public static final String NULLVALUE_VECTOR_FILE_EXTENSION = 
".bitmap.nullvalue";
+    public static final String FST_INDEX_FILE_EXTENSION = ".lucene.fst";
     public static final String LUCENE_TEXT_INDEX_DOCID_MAPPING_FILE_EXTENSION 
= ".lucene.mapping";
     public static final String LUCENE_TEXT_INDEX_FILE_EXTENSION = 
".lucene.index";
+    public static final String FST_V9_INDEX_FILE_EXTENSION = ".lucene.v9.fst";

Review Comment:
   `LUCENE_FST_V9_INDEX_FILE_EXTENSION`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to