gortiz commented on PR #11702: URL: https://github.com/apache/pinot/pull/11702#issuecomment-1784675061
I've replied in https://github.com/apache/pinot/pull/11903#issuecomment-1784637051. The TL;DR: is that it was necessary in order to correctly use the `slf4j` version Spark 3.5 expects in the classpath. As you can see in https://github.com/apache/pinot/pull/11903, spark 3.5 tests fail when using older slf4j versions. As explained in my comment we could: - Keep `log4j2` in 2.17.1 and use `log4j-slf4j18`, which _may_ support `slf4j` v2. I don't like this approach, but may be the easiest to implement. - Keep `log4j2` in 2.20 (or update it to 2.21) and use `log4j-slf4j2`. The contention problem is new to me, we should report it to log4j2 trying to fix it. Keep using log4j2 in v 2.17.1 (released 2 years ago) is problematic. Imagine a new vulnerability is found in that version, we would like to be able to upgrade to the newest version that fixes it. - Try to make the test work somehow. This is my least preferred option because it would just silence a possible runtime error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
