Jackie-Jiang commented on code in PR #11740:
URL: https://github.com/apache/pinot/pull/11740#discussion_r1361297839
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -447,6 +467,9 @@ public RebalanceResult rebalance(TableConfig tableConfig,
RebalanceConfig rebala
// Check version and update IdealState
try {
+ if (_tableRebalanceObserver.isAborted()) {
+ throw new RuntimeException(String.format("Rebalance for table: %s
has been aborted", tableNameWithType));
Review Comment:
This is regular flow. Can we make it returning CANCELLED explicitly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
