klsince commented on code in PR #11740:
URL: https://github.com/apache/pinot/pull/11740#discussion_r1361252175
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -2063,28 +2070,76 @@ public boolean addNewReloadAllSegmentsJob(String
tableNameWithType, String jobId
ZKMetadataProvider.constructPropertyStorePathForControllerJob(ControllerJobType.RELOAD_SEGMENT));
}
+ /**
+ * Adds a new job metadata for controller job like table rebalance or reload
into ZK
+ * @param jobId job's UUID
+ * @param jobMetadata the job metadata
+ * @param jobResourcePath zkPath to add the new job metadata
+ * @return boolean representing success / failure of the ZK write step
+ */
public boolean addControllerJobToZK(String jobId, Map<String, String>
jobMetadata, String jobResourcePath) {
Review Comment:
sgtm. will refactor this here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
