klsince commented on code in PR #11740:
URL: https://github.com/apache/pinot/pull/11740#discussion_r1355848314
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/ZkBasedTableRebalanceObserver.java:
##########
@@ -98,10 +117,9 @@ private void updateOnStart(Map<String, Map<String, String>>
currentState,
@Override
public void onSuccess(String msg) {
- Preconditions.checkState(_tableRebalanceProgressStats.getStatus() !=
RebalanceResult.Status.DONE.toString(),
+
Preconditions.checkState(!RebalanceResult.Status.DONE.toString().equals(_tableRebalanceProgressStats.getStatus()),
Review Comment:
sgtm, will see if der/se works as expected with enum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
