klsince commented on code in PR #11740: URL: https://github.com/apache/pinot/pull/11740#discussion_r1355832863
########## pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java: ########## @@ -199,6 +199,9 @@ public static class ControllerPeriodicTasksConf { // RealtimeSegmentRelocator has been rebranded as SegmentRelocator public static final String DEPRECATED_REALTIME_SEGMENT_RELOCATION_INITIAL_DELAY_IN_SECONDS = "controller.realtimeSegmentRelocation.initialDelayInSeconds"; + public static final String REBALANCE_CHECKER_INITIAL_DELAY_IN_SECONDS = + "controller.rebalanceChecker.initialDelayInSeconds"; + public static final String REBALANCE_CHECKER_CHECK_ONLY = "controller.rebalanceChecker.checkOnly"; Review Comment: I'm fine with removing this feature flag to be simple. I thought there might be cases where users just want to alert when this checker task detects rebalance failure, but retry the rebalance manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org