gortiz commented on code in PR #11729:
URL: https://github.com/apache/pinot/pull/11729#discussion_r1348495585
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/ForwardIndexReader.java:
##########
@@ -916,4 +916,83 @@ default byte[][] getBytesMV(int docId, T context) {
default int getNumValuesMV(int docId, T context) {
throw new UnsupportedOperationException();
}
+
+ class ValueRange {
+ private final long _offset;
+ private final int _size;
+ // To tell if size uses bit or byte as unit, for fwd index reader reading
values of fixed bits.
Review Comment:
Can we use javadoc here instead of single line comments? It would be useful
when reading it from the IDE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
