gortiz commented on code in PR #11729:
URL: https://github.com/apache/pinot/pull/11729#discussion_r1348493740
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/forward/ForwardIndexReaderFactory.java:
##########
@@ -41,7 +41,15 @@
public class ForwardIndexReaderFactory extends
IndexReaderFactory.Default<ForwardIndexConfig, ForwardIndexReader> {
- public static final ForwardIndexReaderFactory INSTANCE = new
ForwardIndexReaderFactory();
+ private static ForwardIndexReaderFactory _instance = new
ForwardIndexReaderFactory();
+
+ public static void setInstance(ForwardIndexReaderFactory factory) {
Review Comment:
I think either the variable should be volatile or we should clearly indicate
here that the instance can only be changed at startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
