klsince commented on code in PR #11730:
URL: https://github.com/apache/pinot/pull/11730#discussion_r1346223520
##########
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##########
@@ -961,13 +960,12 @@ public boolean enableSegmentRelocatorLocalTierMigration()
{
}
public long getSegmentRelocatorExternalViewCheckIntervalInMs() {
- return
getProperty(ControllerPeriodicTasksConf.SEGMENT_RELOCATOR_EXTERNAL_VIEW_CHECK_INTERVAL_IN_MS,
- RebalanceConfigConstants.DEFAULT_EXTERNAL_VIEW_CHECK_INTERVAL_IN_MS);
+ return
getProperty(ControllerPeriodicTasksConf.SEGMENT_RELOCATOR_EXTERNAL_VIEW_CHECK_INTERVAL_IN_MS,
1000L);
Review Comment:
yeah, I tried of leaving those default values in RebalanceConfig class. But
turned out the main use of some of those defaults is actually in
`...spi.utils.builder.ControllerRequestURLBuilder`, while RebalanceConfig is in
pkg `...controller.helix.core.rebalance`, so I simply removed all of those
defaults to be clean (favoring a bit redundancy over dependency).
I'll add the defaults referred in controller pkg back for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
