klsince commented on code in PR #11730: URL: https://github.com/apache/pinot/pull/11730#discussion_r1344864417
########## pinot-spi/src/main/java/org/apache/pinot/spi/utils/RebalanceConfigConstants.java: ########## @@ -19,18 +19,13 @@ package org.apache.pinot.spi.utils; /** - * Constants for rebalance config properties + * Defaults for rebalance configs are defined here. But use RebalanceConfig to define the configs, and deprecate Review Comment: love to. no more references to the config names defined here after this cleanup, but there are still references to the default config values defined here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org