abhioncbr commented on PR #11653: URL: https://github.com/apache/pinot/pull/11653#issuecomment-1741888203
> This is not the correct way to support null in `ScalarTransformFunctionWrapper` because for scalar function, the result might not be `null` when one of the input values is `null`. It needs to extends `ComputeDifferentlyWhenNullHandlingEnabledTransformFunction` and handle `null` differently. > > We may keep the change in this PR as it adds default null support to more functions, and make a separate PR for `ScalarTransformFunctionWrapper` Thanks for mentioning. I updated the PR title per the changes and will raise another PR for `ScalarTransformFunctionWrapper`. Please review the PR once more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
