abhioncbr commented on code in PR #11653:
URL: https://github.com/apache/pinot/pull/11653#discussion_r1341865991
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java:
##########
@@ -297,6 +297,7 @@ public DataType toDataType() {
case TIMESTAMP:
case TIMESTAMP_ARRAY:
return DataType.TIMESTAMP;
+ case OBJECT:
Review Comment:
This is added to confirm the test. This shouldn't be here.
Question: to determine the `TransformResultMetadata _resultMetadata` in
`ScalarTransformFunctionWrapper` for `Object` resultType; what should we do?
Like in `CaseTransformFunction` we have
[calculateResultMetadata](https://github.com/apache/pinot/blob/master/pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunction.java#L102),
do we have to do similar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
