Jackie-Jiang commented on code in PR #11692: URL: https://github.com/apache/pinot/pull/11692#discussion_r1338053942
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ########## @@ -80,17 +79,18 @@ public abstract class BasePartitionUpsertMetadataManager implements PartitionUps protected volatile boolean _gotFirstConsumingSegment = false; protected final ReadWriteLock _snapshotLock; - protected volatile boolean _stopped = false; - // Initialize with 1 pending operation to indicate the metadata manager can take more operations - protected final AtomicInteger _numPendingOperations = new AtomicInteger(1); - protected long _lastOutOfOrderEventReportTimeNs = Long.MIN_VALUE; protected int _numOutOfOrderEvents = 0; // Used to maintain the largestSeenComparisonValue to avoid handling out-of-ttl segments/records. // If upsertTTL enabled, we will keep track of largestSeenComparisonValue to compute expired segments. protected volatile double _largestSeenComparisonValue; + private boolean _stopped; Review Comment: Good point, added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
