Jackie-Jiang opened a new pull request, #11692: URL: https://github.com/apache/pinot/pull/11692
Even though very unlikely, there is still a code path which can potentially access the upsert metadata after the manager is closed: - Thread 1 finishes the `_stopped` flag check but not invoking `startOperation()` yet - Thread 2 stops and closes the metadata manager - Thread 1 calls `startOperation()` and start accessing the metadata In this PR, make `startOperation()` return false if the pending operations (reference count) already drops to 0, and also merge `stopped` flag check into `startOperation()` to simplify the logic. This is not super performance sensitive, so using very tight synchronized block should be fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
