ankitsultana commented on code in PR #11561:
URL: https://github.com/apache/pinot/pull/11561#discussion_r1330433141
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaConsumerFactory.java:
##########
@@ -25,18 +25,22 @@
public class KafkaConsumerFactory extends StreamConsumerFactory {
+ private static final String _PARTITION_LEVEL_CONSUMER =
".partition_level_consumer";
+ private static final String _PARTITION_METADATA_PROVIDER =
".partition_metadata_provider";
+ private static final String _STREAM_METADATA_PROVIDER =
".stream_metadata_provider";
+
@Override
public PartitionLevelConsumer createPartitionLevelConsumer(String clientId,
int partition) {
- return new KafkaPartitionLevelConsumer(clientId, _streamConfig, partition);
+ return new KafkaPartitionLevelConsumer(clientId +
_PARTITION_LEVEL_CONSUMER, _streamConfig, partition);
Review Comment:
Since Kafka puts the clientId in its metrics, this might change metrics for
people who use them right now.
cc: @mcvsubbu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
