eaugene commented on code in PR #11561:
URL: https://github.com/apache/pinot/pull/11561#discussion_r1321780374
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/PartitionGroupMetadataFetcher.java:
##########
@@ -63,8 +65,8 @@ public Exception getException() {
@Override
public Boolean call()
throws Exception {
- String clientId = PartitionGroupMetadataFetcher.class.getSimpleName() + "-"
- + _streamConfig.getTableNameWithType() + "-" + _topicName;
+ String clientId = PartitionGroupMetadataFetcher.class.getSimpleName() +
"-" + _topicName + "-try" + Integer
+ .toString(++_callRetries);
Review Comment:
1. They are already existing code & all stream tech ( kafka , pulsar,
kinesis ) have a topic name .
2. Yes . But here the mBean would be already existing , so we would only
ending up with a warning in logs
3. This is a temporary solution . I did put up a fix in kafka for the same
https://github.com/apache/kafka/pull/14287 ( this is approved ) , but not sure
how soon we would upgrade the packages to have it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
