gortiz commented on PR #11484: URL: https://github.com/apache/pinot/pull/11484#issuecomment-1704726474
> Does it work if user explicitly select virtual column? Yes. This method is only called when adding columns in `select *`. The main issue is that is not explicitly said in Calcite's javadoc. I've added a comment including the discussion in Calcite dev email list when Julian Hyde says this is not a supported feature and invite us to add a proposal (something we should do, but I guess we want to solve the issue first). I've added a couple of test to verify the behavior and detect a possible regression in future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
