Jackie-Jiang commented on code in PR #11484:
URL: https://github.com/apache/pinot/pull/11484#discussion_r1313412663
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/validate/Validator.java:
##########
@@ -124,4 +129,19 @@ private static String getColumnName(SqlIdentifier
identifier) {
List<String> names = identifier.names;
return names.get(names.size() - 1);
}
+
+ protected void addToSelectList(
+ List<SqlNode> list,
+ Set<String> aliases,
+ List<Map.Entry<String, RelDataType>> fieldList,
+ SqlNode exp,
+ SelectScope scope,
+ final boolean includeSystemVars) {
+ if (exp.getKind() == SqlKind.IDENTIFIER) {
+ if ((((SqlIdentifier) exp).names).stream().anyMatch(s ->
s.startsWith("$"))) {
Review Comment:
Does it work if user explicitly select virtual column?
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/validate/Validator.java:
##########
@@ -124,4 +129,19 @@ private static String getColumnName(SqlIdentifier
identifier) {
List<String> names = identifier.names;
return names.get(names.size() - 1);
}
+
+ protected void addToSelectList(
Review Comment:
(minor)
- Add `@Override`
- Follow Pinot Style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
